Change module structure. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tikue
force-pushed
the
mod-structure
branch
4 times, most recently
from
3a56280 to
48091cc
Compare
tikue
force-pushed
the
mod-structure
branch
2 times, most recently
from
3080779 to
8b62be1
Compare
…processing client requests. The largest benefit is that unit testing becomes easier, e.g. testing that the request processing stops when all request senders are dropped.
Rather than reimplement the same logic. Curiously, this commit isn't a net loss in LOC. Oh well.
shaladdle
requested changes
Mar 7, 2017
Cargo.toml
Outdated
| @@ -38,6 +38,7 @@ chrono = "0.3" | |||
| env_logger = "0.3" | |||
| futures-cpupool = "0.1" | |||
| clap = "2.0" | |||
| service-fn = { git = "https://github.com/tokio-rs/service-fn" } | |||
There was a problem hiding this comment.
I prefer we pin to a specific hash if there's no crate. Is that OK or do you still want to track master?
src/errors.rs
Outdated
| @@ -84,7 +80,7 @@ impl<E> From<WireError<E>> for Error<E> { | |||
| #[derive(Deserialize, Serialize, Clone, Debug)] | |||
| pub enum WireError<E> { | |||
| /// Error in serializing the server response or deserializing the client request. | |||
There was a problem hiding this comment.
Is this comment still accurate? If so it's confusing that this can be for a failed deserialize of a response.
shaladdle
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous:
client::{sync, future}andserver::{sync, future}Now:
sync::{client, server}andfuture::{client, server}The instigation for this is that, when there are separate sync/future versions of
Options, they'd have to be fully qualified as, e.g.,server::sync::Options, becausesync::Optionscould be client options or server options.But also, I expect users will usually be using all futures or all sync, and this makes that a bit more ergonomic. You can just do
rather than
This is built off of #117 and #121 because I didn't want to end up dealing with a bunch of merge conflicts.
Fixes #66
Fixes #123