expose some structs to be able to use a non-tokio executor #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tikue
reviewed
Apr 13, 2020
| @@ -28,7 +28,7 @@ pub mod client; | |||
| pub mod context; | |||
| pub mod server; | |||
| pub mod transport; | |||
| pub(crate) mod util; | |||
| pub mod util; | |||
There was a problem hiding this comment.
What did you need util for? This module isn't intended to be publicly exposed.
|
Sorry for the long wait! Given that we don't currently have a better way to make tarpc executor agnostic, I think I'm basically okay with this. I'm a little concerned about forward compatibility hazards, but not sufficiently concerned to block this. |
tikue
force-pushed
the
master
branch
6 times, most recently
from
978f374 to
66cdc99
Compare
|
@vhdirk I'm sorry this languished for so long! :( I think it's best at this point to close it. I think there's still a conversation to be had about how best to support different executors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Inox(https://github.com/vhdirk/inox/) I'm combing tarpc with the glib executor as opposed to the default tokio executor.
In order to also have deadlines for requests, I needed to fork
ClientHandlerin my own project. That requires some changes in tarpc so I can create, for instance, a response struct. See https://github.com/vhdirk/inox/blob/master/inox-gtk/src/webextension/rpc.rsI'm still working on the client side. That one is harder since tokio's
TimeOuts are not compatible with custom executors, but they are used throughout the (generated) client code.