Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mans support parser #1206

Closed
garanews opened this issue May 20, 2020 · 4 comments
Closed

Add mans support parser #1206

garanews opened this issue May 20, 2020 · 4 comments
Assignees

Comments

@garanews
Copy link
Contributor

Created #1205 that replaces the #937 and uses mans_to_es as library instead of external tool.
Will follow new pr with documentation and docker support.
Regarding docker: there are 2 other pr waiting that we need:
#1195
#1174
We can create one pr that includes all we need (idna, python3-setuptools ,python3-wheel , build-essential to compile required dependencies ) or wait the merge of those pr and create a pr with only build-essentials inside.
What do you think?

@kiddinn
Copy link
Contributor

kiddinn commented May 22, 2020

@berggren since you were working on the re-factoring of all things docker, can you respond here?

@garanews
Copy link
Contributor Author

Another thing, what about upgrade some library?
We had to tweak our dependencies in order to do not break yours:
numpy>=1.16.6
pandas>=0.24.2

Our code works with any issue with:
numpy==1.18.4
pandas==1.0.3

Is still necessary to support py2?

@kiddinn
Copy link
Contributor

kiddinn commented May 25, 2020

Another thing, what about upgrade some library?
We had to tweak our dependencies in order to do not break yours:
numpy>=1.16.6
pandas>=0.24.2

Our code works with any issue with:
numpy==1.18.4
pandas==1.0.3

I'll update the requirements file

Is still necessary to support py2?

no....

@berggren
Copy link
Contributor

@berggren since you were working on the re-factoring of all things docker, can you respond here?

Yeah, this has been fixed in #1207 as part of a larger refactor and fixit for docker in TS. We now build base images automatically that is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants