Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for FireEye HX .mans files #1205

Merged
merged 6 commits into from
May 21, 2020
Merged

add support for FireEye HX .mans files #1205

merged 6 commits into from
May 21, 2020

Conversation

garanews
Copy link
Contributor

@garanews garanews commented May 20, 2020

add support for mans files using mans_to_es library

Co-Authored-By: @dadokkio

add support for mans files using mans_to_es library

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
@dadokkio
Copy link
Contributor

@googlebot I fixed it.

Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
garanews and others added 2 commits May 20, 2020 10:36
Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
@garanews
Copy link
Contributor Author

@googlebot I fixed it.

@garanews
Copy link
Contributor Author

garanews commented May 20, 2020

@kiddinn This replace the #937

@garanews garanews changed the title add support for mans files add support for FireEye HX .mans files May 20, 2020
@jaegeral
Copy link
Collaborator

Hm something is still wrong with the CLA form.

@dadokkio is the mentioned gmail alias: dadokkio@gmail.com linked to your github account?

Maybe it is easier if @garanews changes the co-author to the github account name, not the email alias?

@garanews
Copy link
Contributor Author

Hello @jaegeral , I just changed in comment, should I do anything else?

@dadokkio
Copy link
Contributor

I've just signed the cla with both my google accounts, so now it should be ok.

@dadokkio
Copy link
Contributor

@googlebot I fixed it.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@garanews
Copy link
Contributor Author

@googlebot I consent.

1 similar comment
@dadokkio
Copy link
Contributor

@googlebot I consent.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jaegeral
Copy link
Collaborator

perfect thank you very much, now up for review of @kiddinn or @berggren

@garanews
Copy link
Contributor Author

garanews commented May 20, 2020

Some screenshot:

immagine
immagine
immagine
a1a

@kiddinn kiddinn self-requested a review May 20, 2020 13:35
Copy link
Contributor

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a very minor comment here, otherwise looks good

timesketch/lib/tasks.py Show resolved Hide resolved
@kiddinn
Copy link
Contributor

kiddinn commented May 20, 2020

and you'll need to update your branch, since it is out-of-date with the base branch

Copy link
Contributor

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one qq

timesketch/lib/tasks.py Show resolved Hide resolved
@kiddinn kiddinn self-requested a review May 21, 2020 12:40
Copy link
Contributor

@kiddinn kiddinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... and sorry for the long time it took to get the review done.

@kiddinn kiddinn merged commit 22dde20 into google:master May 21, 2020
@garanews
Copy link
Contributor Author

Here logs under celery folder logs:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants