Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle special characters in queries and filter chips #3168

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Aug 26, 2024

This PR addresses an issue where OpenSearch incorrectly interpreted special characters in queries and filter chips.

  • Special character-only queries are now handled as term queries on the .keyword sub-field, ensuring accurate matching without analysis.
  • Filter chips of type "term" consistently use the .keyword sub-field if they are of type String.
  • Removed include/exclude icons for datetime and tag fields to avoid user confusion.

This change improves query accuracy and filter chip functionality, providing a more intuitive user experience.

Closing issues

closes #3103

* Removing the filter chip icons for fields that are known not to behave as expected.
@jkppr jkppr requested a review from berggren August 26, 2024 15:55
@jkppr jkppr self-assigned this Aug 26, 2024
@jkppr jkppr merged commit 7e91aef into google:master Aug 28, 2024
24 checks passed
@jkppr jkppr deleted the fix-3103 branch August 28, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter "working_dir: /" didn't properly filter
2 participants