Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for DFIQ data import #3170

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Error handling for DFIQ data import #3170

merged 4 commits into from
Aug 28, 2024

Conversation

jkppr
Copy link
Collaborator

@jkppr jkppr commented Aug 28, 2024

This PR fixes a bug with the handling of older DFIQ versions.

  • Add checks for min supported DFIQ version before importing the data.
  • Catching errors if the imported data does not have the supported fields.

@jkppr jkppr requested a review from berggren August 28, 2024 11:23
@jkppr jkppr self-assigned this Aug 28, 2024
@jkppr jkppr merged commit 29ef31f into google:master Aug 28, 2024
24 checks passed
@jkppr jkppr deleted the tsdfiq-fix-keyerror branch August 28, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berggren berggren berggren approved these changes

Assignees

@jkppr jkppr

Labels
Backend Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkppr @berggren