Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace '(or blank)' to 'or empty' #501

Closed
skinkie opened this issue Sep 18, 2024 · 1 comment · Fixed by #510
Closed

Replace '(or blank)' to 'or empty' #501

skinkie opened this issue Sep 18, 2024 · 1 comment · Fixed by #510
Labels
Change: Clarification Revisions of the current specification to improve understanding. GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Status: Discussion Issues and Pull Requests that are currently being discussed and reviewed by the community. Support: Needs Feedback

Comments

@skinkie
Copy link
Contributor

skinkie commented Sep 18, 2024 •
edited
Loading

We use the wording (or blank) within stops.txt while using 'or empty' in other place.
@eliasmbd eliasmbd added GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Status: Discussion Issues and Pull Requests that are currently being discussed and reviewed by the community. Change: Clarification Revisions of the current specification to improve understanding. Support: Needs Feedback labels Sep 23, 2024
@tzujenchanmbd
Copy link
Collaborator

Thanks for catching this! We will open a PR to revise it.

skalexch added a commit to skalexch/transit that referenced this issue Oct 10, 2024
@skalexch
Change blank to empty for location type in stops.txt
5833086 
To maintain consistency.
Closes google#501
@skalexch skalexch mentioned this issue Oct 10, 2024
Closed
skalexch pushed a commit that referenced this issue Oct 16, 2024
Change blank to empty for location type in stops.txt
7f94893 
To maintain consistency with the wording in the rest of the spec. It says "(or empty)" everywhere except for location_type in stops.txt
Closes #501

No voting needed as it is a minor revision.
@skalexch skalexch mentioned this issue Oct 16, 2024
Closed
skalexch added a commit that referenced this issue Oct 16, 2024
@skalexch
Change blank to empty for location type in stops.txt
8034728 
To maintain consistency with the wording in the rest of the spec. It says "(or empty)" everywhere except for location_type in stops.txt
Closes #501

No voting needed as it is a minor revision.
@skalexch skalexch mentioned this issue Oct 16, 2024
Merged
skalexch added a commit that referenced this issue Oct 16, 2024
@skalexch
Change blank to empty for location type in stops.txt (#510)
b8687cb 
To maintain consistency with the wording in the rest of the spec. It says "(or empty)" everywhere except for location_type in stops.txt
Closes #501

No voting needed as it is a minor revision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Change: Clarification Revisions of the current specification to improve understanding. GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Status: Discussion Issues and Pull Requests that are currently being discussed and reviewed by the community. Support: Needs Feedback
Projects
None yet
Milestone
No milestone
3 participants
@skinkie @tzujenchanmbd @eliasmbd