Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shapes.geojson #393

Closed
wants to merge 1 commit into from
Closed

Shapes.geojson #393

wants to merge 1 commit into from

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Aug 8, 2023

No description provided.

@tzujenchanmbd tzujenchanmbd added the GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Sep 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 2, 2023
@skinkie
Copy link
Contributor Author

skinkie commented Sep 2, 2023

Keep open.

@github-actions github-actions bot removed the stale label Sep 3, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 27, 2023
@tsherlockcraig
Copy link

We'd need to get producers and consumers to go along, but for what I use GTFS for internally at WSDOT I'd support this change due simply to the ease at which I could visualize shapes.

One question: in shapes.txt there is a shape_dist_traveled value attached to every point in the line string, but in this proposal, it looks like there's just the one shape_dist_traveled total for the entire line string. Does this need to be adjusted to somehow attach a shape_dist_traveled to every point in the linestring array, or, is that unnecessary because it's actually only stop_times.shape_dist_traveled which needs to be used in order to disambiguate stops within loops?

@skinkie
Copy link
Contributor Author

skinkie commented Sep 27, 2023

One question: in shapes.txt there is a shape_dist_traveled value attached to every point in the line string, but in this proposal, it looks like there's just the one shape_dist_traveled total for the entire line string. Does this need to be adjusted to somehow attach a shape_dist_traveled to every point in the linestring array, or, is that unnecessary because it's actually only stop_times.shape_dist_traveled which needs to be used in order to disambiguate stops within loops?

This is something you can only do if you would split the shape up in sub-stop-stop-pieces, which completely defeats the purpose of simplicity. Technically the representation within the current shapes.txt format allows for a higher precision than as the crow flies between two points, allowing to generate abstract shapes (for example for long distance busses and rail) but retaining the ability to attach the correct distance. Since we have a stop-stop-distance it does not interfere with average driving speed checks. So it might well be that shapes.geojson is most effectively used with a percentage, or would require a shape to be split up between two stops, opposed to the full journey with shapes.txt.

@github-actions github-actions bot removed the stale label Sep 28, 2023
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 22, 2023
@skinkie
Copy link
Contributor Author

skinkie commented Oct 22, 2023

Keep open.

@github-actions github-actions bot removed the stale label Oct 23, 2023
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 15, 2023
@skinkie
Copy link
Contributor Author

skinkie commented Nov 15, 2023

Keep open.

@github-actions github-actions bot removed the stale label Nov 16, 2023
@doconnoronca
Copy link
Contributor

The GTFS real-time specification already has an experimental specification for a Google encoded polylines. Having lines encoded using two different formats in the same specification is probably not a good idea.

@skinkie
Copy link
Contributor Author

skinkie commented Dec 4, 2023

That argument did not make it for GTFS-Flex.

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 28, 2023
Copy link

github-actions bot commented Jan 4, 2024

This pull request has been closed due to inactivity. Pull requests can always be reopened after they have been closed. See the Specification Amendment Process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants