-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate Log Update Failures in AddSequencedLeaves #1544
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
+ Coverage 66.12% 67.24% +1.12%
==========================================
Files 103 105 +2
Lines 7013 8586 +1573
==========================================
+ Hits 4637 5774 +1137
- Misses 1884 2230 +346
- Partials 492 582 +90
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this much needed change.
Just a few suggestions on using the status
library for easier handling of the status
I'll also loop in @Martin2112 for his approval.
wdyt @Martin2112 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.
@Martin2112 FYI
LogId: c.LogID, | ||
Leaves: leaves, | ||
}) | ||
for _, leaf := range resp.GetResults() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the client doesn't get to find out which leaves already exist. Maybe that doesn't matter.
/gcbrun |
Co-Authored-By: therealdrake <alexdrake@google.com>
Co-Authored-By: therealdrake <alexdrake@google.com>
/gcbrun |
AddSequencedLeaves in the log client previously did not evaluate the response proto. Adding some fail case checking and logging.