Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded protoc version to latest #2088

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Conversation

mhutchinson
Copy link
Contributor

Checklist

@mhutchinson mhutchinson requested a review from a team as a code owner April 22, 2020 11:14
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #2088 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2088   +/-   ##
=======================================
  Coverage   58.92%   58.92%           
=======================================
  Files         115      115           
  Lines        9778     9778           
=======================================
  Hits         5762     5762           
  Misses       3513     3513           
  Partials      503      503           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb8c50...d237e88. Read the comment docs.

@pav-kv pav-kv removed the request for review from benlaurie April 22, 2020 11:19
@mhutchinson mhutchinson changed the title Extracted protoc version into variable before upgrading it Upgraded protoc version to latest Apr 22, 2020
@mhutchinson
Copy link
Contributor Author

@pavelkalinnikov I've made the upgrade change in this PR too. Are you happy with this?

This didn't have the effect I expected, but at least it rules something out about why the docs are being generated with diffs in #2087, and this seems like a good thing to keep updated too.

I'll squash the commits in this PR together when merging.

@pav-kv
Copy link
Contributor

pav-kv commented Apr 22, 2020

LGTM.

@mhutchinson mhutchinson merged commit c9a46df into google:master Apr 22, 2020
@mhutchinson mhutchinson deleted the updateProtoc branch April 22, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants