log: Clean-up operation loop #2294
Conversation
|
PTAL. Commit-by-commit review is recommended. |
|
Also, I recommend to "Hide whitespace changes" when reviewing this. |
|
Travis is stuck, doesn't start any builds. |
|
Added a mini-commit to trigger Travis again. |
|
@Martin2112 @AlCutter I added another cosmetic commit, which eliminates the goto-like "break label" construction, by factoring out another method. You may want to review this last commit just in case. |
|
LGTM |
pav-kv
force-pushed
the
log_operation_cleanup
branch
from
5b641e9
to
4b5b25f
Compare
|
Nice. New integration tests in Could Build pass. I will merge this after playing with CB a little more and ensuring it has all the necessary coverage. |
A few lines above there is glog printing the number of processed entries, and processing time. There is not much sense in aggregating the number of processed entries across log IDs for glog purposes, this info is better represented in already existing metrics.
This not only makes the code simpler, but prepares it for inverting control in follow-up commits. Previously, workers invoked per-logID functions, but after the refactoring each log will have a dedicated worker.
pav-kv
force-pushed
the
log_operation_cleanup
branch
from
4b5b25f
to
274664f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2294 +/- ##
==========================================
+ Coverage 65.04% 65.51% +0.46%
==========================================
Files 118 115 -3
Lines 8907 8816 -91
==========================================
- Hits 5794 5776 -18
+ Misses 2454 2383 -71
+ Partials 659 657 -2
Continue to review full report at Codecov.
|
This change simplifies log operation loop in preparation for a structural refactoring.
Review commit-by-commit.
#1640