Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CockroachDB: Optimize quota manager by using follower reads #2853

Merged

Conversation

JAORMX
Copy link
Collaborator

@JAORMX JAORMX commented Nov 23, 2022

This takes into use CockroachDB's follower reads feature [1] which
allows for the expensive SELECT query to be executed on a local node
instead of the leader. This reduces latency for multi-region
deployments; though it slows down the tests as we now allow for some
time for the database writes to converge.

[1] https://www.cockroachlabs.com/docs/stable/follower-reads.html#when-to-use-exact-staleness-reads

Checklist

This takes into use CockroachDB's follower reads feature [1] which
allows for the expensive `SELECT` query to be executed on a local node
instead of the leader. This reduces latency for multi-region
deployments; though it slows down the tests as we now allow for some
time for the database writes to converge.

[1] https://www.cockroachlabs.com/docs/stable/follower-reads.html#when-to-use-exact-staleness-reads

Signed-off-by: Juan Antonio Osorio <juan.osoriorobles@eu.equinix.com>
@JAORMX JAORMX requested a review from a team as a code owner November 23, 2022 12:25
@JAORMX JAORMX requested a review from pphaneuf November 23, 2022 12:25
@roger2hk
Copy link
Contributor

/gcbrun

@roger2hk roger2hk requested review from AlCutter and removed request for pphaneuf November 23, 2022 13:08
@AlCutter AlCutter merged commit 8cfc251 into google:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants