Deprecate Optional*Subject.hasValueThat() and the overload of `Stan…

…dardSubjectBuilder.fail(...)` that accepts a message.

Relnotes:
  Deprecated the overload of `StandardSubjectBuilder.fail(...)` that accepts a message. Instead of `assert_().fail(...)`, use `assertWithMessage(...).fail()`. Similarly, instead of `expect.fail(...)`, use `expect.withMessage(...).fail()`, and so forth.
  Deprecated `Optional*Subject.hasValueThat()`. Instead of `assertThat(optional).hasValueThat()....`, use `assertThat(optional.getAs*())....`.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=254050317

core/src/main/java/com/google/common/truth/StandardSubjectBuilder.java

@@ -220,12 +220,19 @@ public final <CustomSubjectBuilderT extends CustomSubjectBuilder> CustomSubjectB
     return factory.createSubjectBuilder(metadata());
   }
 
-  /** Triggers the failure strategy with an empty failure message */
+  /** Triggers the failure strategy with an empty failure message. */
   public final void fail() {
     doFail("");
   }
 
-  /** Triggers the failure strategy with the given failure message */
+  /**
+   * Triggers the failure strategy with the given failure message.
+   *
+   * @deprecated Instead of {@code assert_().fail(...)}, use {@code assertWithMessage(...).fail()}.
+   *     Similarly, instead of {@code expect.fail(...)}, use {@code expect.withMessage(...).fail()},
+   *     and so forth.
+  */
+  @Deprecated
   public final void fail(@NullableDecl String format, Object /*@NullableDeclType*/... args) {
     doFail(lenientFormat(format, args));
   }

extensions/java8/src/main/java/com/google/common/truth/OptionalDoubleSubject.java

@@ -81,7 +81,11 @@ public void hasValue(double expected) {
   /**
    * Prepares for a check regarding the value contained within the {@link OptionalDouble}. Fails
    * immediately if the subject is empty.
-   */
+   *
+   * @deprecated Instead of {@code assertThat(optional).hasValueThat()....}, use {@code
+   *     assertThat(optional.getAsDouble())....}.
+  */
+  @Deprecated
   public DoubleSubject hasValueThat() {
     if (actual == null || !actual.isPresent()) {
       isPresent(); // fails

extensions/java8/src/main/java/com/google/common/truth/OptionalIntSubject.java

@@ -74,7 +74,11 @@ public void hasValue(int expected) {
   /**
    * Prepares for a check regarding the value contained within the {@link OptionalInt}. Fails
    * immediately if the subject is empty.
-   */
+   *
+   * @deprecated Instead of {@code assertThat(optional).hasValueThat()....}, use {@code
+   *     assertThat(optional.getAsInt())....}.
+  */
+  @Deprecated
   public IntegerSubject hasValueThat() {
     if (actual == null || !actual.isPresent()) {
       isPresent(); // fails

extensions/java8/src/main/java/com/google/common/truth/OptionalLongSubject.java

@@ -74,7 +74,11 @@ public void hasValue(long expected) {
   /**
    * Prepares for a check regarding the value contained within the {@link OptionalLong}. Fails
    * immediately if the subject is empty.
-   */
+   *
+   * @deprecated Instead of {@code assertThat(optional).hasValueThat()....}, use {@code
+   *     assertThat(optional.getAsLong())....}.
+  */
+  @Deprecated
   public LongSubject hasValueThat() {
     if (actual == null || !actual.isPresent()) {
       isPresent(); // fails