Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump a bunch of deps at once. #1151

Closed
wants to merge 0 commits into from
Closed

Conversation

copybara-service[bot]
Copy link
Contributor

Bump a bunch of deps at once.

Notes:

  • The GWT bump requires changing the browser setting from "FF38" to "FF."
  • I skipped the jsinterop-annotations bump to 2.1.0 because it's built
    with -target 11, while we still support 8.
    (Closes Bump com.google.jsinterop:jsinterop-annotations from 2.0.0 to 2.1.0 #1147)
    (I've noted this in Figure out when to drop Java 8 support guava#6614)
  • The command I used is:
    mvn org.codehaus.mojo:versions-maven-plugin:2.16.0:{update-properties,use-latest-releases} -DgenerateBackupPoms=false -Dexcludes=com.google.guava:guava
    
    That tried to update protobuf to a release candidate. I had thought
    that perhaps this was the result of a protobuf change from "-rc1" to
    "-rc-1"
    , but
    I'm wondering if it's actually just that versions-maven-plugin (in
    contrast to Dependabot) counts release candidates as
    releases
    ?
    I'd have to investigate further and perhaps use
    rulesUri
    . But since we
    normally rely on Dependabot (and I was using versions-maven-plugin
    here only "to make things easier"... :)), I'm not going to worry about
    it now.
    ...
    Also, it looks like protobuf 4 might remove the hasPresence() method
    that we'd migrated to back in cl/508716698. If so, there's a good
    chance that the protobuf team will fix things for us :) If not, I'm
    assuming that this will relate to
    "Editions."

Fixes #1149
Fixes #1148
Fixes #1146
Fixes #1145

Fixes #1150

RELNOTES=n/a

@cpovirk
Copy link
Member

cpovirk commented Aug 8, 2023

(It's possible that we don't need to declare a jsinterop dependency at all, as discussed in google/guava#6614 (comment). But I would not count on our existing testing to verify that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant