Detector CVE-2021-3129

[timoles]

Hey Google Tsunami Team,

my PR for the Vuln Detector Plugin for CVE-2021-3129 (see Issue #86)

I used the following docker images to verify the vulnerability. I should note that I made my own images as I couldn't get the official bitnami/laravel images to run without also requiring a db server for the startup. Also, the bitnami/laravel:8.4.2 docker image, which you would expect to be vulnerable to CVE-2021-3129, is not vulnerable as it builds with a patched dependency of facade/ignition. (However, any servers build before the facade/ignition patch are still vulnerable).

Vulnerable image:

docker run -p 8000:8000 timoles/laravel_cve_2021_3129_ubuntu

Safe image:

docker run -p 8000:8000 timoles/laravel_cve_2021_3129_fixed_ubuntu

Happy to hear your feedback :)

[magl0]

First round of coder review. I mostly focused on code styles and other obvious issues. Detection logic hasn't been checked yet.

[timoles]

First round of coder review. I mostly focused on code styles and other obvious issues. Detection logic hasn't been checked yet.

@magl0 Thanks a lot for the style suggestions. For now style wise everything should (hopefully) check out :) .

[magl0]

In addition to the inline comments, can you please also:

1. Migrate the detector code to community/detectors? Just to be consistent with the rest of the repo.
2. Can you please also update the community/README.md file and add a link to this detector code?

[timoles]

Ready for another round :)

[magl0]

Code style looking good now. We'll start verifying the payload and tests.

[magl0]

This is still under code reviews and payload verification process from a third eye in the Tsunami scanner team. Once it passes we'll merge the pull request. We'll let you know if we found additional issues.