Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI PRP: Request New Web Fingerprint for Kubeflow Model UI #422 #488

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

hayageek
Copy link
Contributor

@hayageek hayageek commented May 21, 2024

Hi @maoning, @tooryx,
This PR is linked to an accepted AI PRP: Request New Web Fingerprint for Kubeflow Model UI #422 . It covers versions 0.7.0 to 0.10.0

I have tested the changes with the scanner.
Please find the attached screenshots for the scan log & json output.

kubeflow-json-output kubeflow-log

Copy link

google-cla bot commented May 21, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@hayageek
Copy link
Contributor Author

hayageek commented Jun 11, 2024

Hi @tooryx ,
Can you verify and merge the pull request

@leonardo-doyensec
Copy link
Collaborator

Hello @hayageek,
thank you for your contribution. I'm noticing that there is a new version, which is v0.13.0-rc.0. Can you please add it?

Feel free to reach out
~ Leonardo (Doyensec)

@hayageek
Copy link
Contributor Author

hayageek commented Jul 12, 2024

Hi @leonardo-doyensec ,
I have added v0.13.0-rc.0, and tested the scanner. I have attached the screenshots for your reference.
Screenshot 2024-07-12 at 9 01 26 PM
Screenshot 2024-07-12 at 9 02 03 PM

@hayageek
Copy link
Contributor Author

@leonardo-doyensec any update ?

1 similar comment
@hayageek
Copy link
Contributor Author

@leonardo-doyensec any update ?

@tooryx tooryx linked an issue Jul 26, 2024 that may be closed by this pull request
@hayageek
Copy link
Contributor Author

hayageek commented Jul 30, 2024

Hi @leonardo-doyensec ,
Are you waiting for another version from Kubeflow?

@leonardo-doyensec
Copy link
Collaborator

LGTM - Approved
@maoning you can merge it.

Reviewer: Leonardo, Doyensec
Plugin: Kubeflow Model UI Fingerprints
Feedback: Besides the version.txt file being initially incomplete, due to time delays, the script worked first try and the quality is good.
Drawbacks: None

@tooryx tooryx added the lgtm label Jul 30, 2024
@tooryx tooryx assigned tooryx and unassigned tooryx Jul 31, 2024
@tooryx tooryx self-requested a review August 7, 2024 14:14
@tooryx tooryx added the Contributor main The main issue a contributor is working on (top of the contribution queue). label Aug 7, 2024
Add trailing newline
Add trailing newline
Copy link
Member

@tooryx tooryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hayageek. This should be merged soon.

@copybara-service copybara-service bot merged commit a634ddb into google:master Aug 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor main The main issue a contributor is working on (top of the contribution queue). fingerprints lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI PRP: Request New Web Fingerprint for Kubeflow Model UI
3 participants