Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CVE-2024-3104 Detector Plugin #514

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

frkngksl
Copy link
Contributor

Hi @tooryx ,

This is the plugin PR that resolves #504

Vulnerable and Fixed Environments are here: google/security-testbeds#70

Copy link
Collaborator

@leonardo-doyensec leonardo-doyensec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frkngksl.
Thank you for your contribution. I'm noticing that both the plugin and the testbed works out of the box. This is wonderful. You can find a minor issue to address down below.

Feel free to reach out
~ Leonardo (Doyensec)

@frkngksl
Copy link
Contributor Author

Could you check again @leonardo-doyensec ?

@leonardo-doyensec
Copy link
Collaborator

LGTM - Approved
@maoning we can merge this. Moreover we can also merge the google/security-testbeds#70

Reviewer: Leonardo, Doyensec
Plugin: CVE-2024-3104 Detector
Feedback: The overall quality is superlative. The security testbed is easy to deploy, well explained and works perfectly. The plugin contains everything that is necessary for a fast detection of the vulnerability. Bonus point for the responsiveness of the author.
Drawback: None.

@leonardo-doyensec leonardo-doyensec self-assigned this Jul 11, 2024
@tooryx tooryx added the lgtm label Jul 19, 2024
@tooryx tooryx added the Contributor main The main issue a contributor is working on (top of the contribution queue). label Aug 6, 2024
@tooryx tooryx self-requested a review August 8, 2024 09:21
Copy link
Member

@tooryx tooryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @frkngksl,

This should be merged in a few days.

~tooryx

@frkngksl
Copy link
Contributor Author

frkngksl commented Aug 8, 2024

Hi @tooryx , thanks a lot for the approval. After the merge, could you select an issue from my queue to work on it?

@copybara-service copybara-service bot merged commit a8136e7 into google:master Aug 14, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor main The main issue a contributor is working on (top of the contribution queue). lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI PRP: RCE in anything-llm CVE-2024-3104
3 participants