Add test case and fix for annotation processor option with space #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guw
force-pushed
the
main
branch
3 times, most recently
from
86174eb
to
b983a53
Compare
guw
commented
Aug 29, 2023
cushon
requested changes
Sep 8, 2023
There was a problem hiding this comment.
I think the issue with the existing params file logic is the use of ARG_SPLITTER.split(Files.readString(paramsPath)). ARG_SPLITTER splits on 'breaking whitespace', which includes both spaces and newlines, and it seems like for params files we should only be splitting on newlines.
I wonder if we could replace the use of ARG_SPLITTER.split(Files.readString(paramsPath)) with Files.readAllLines(paramsPath) instead, do you see issues with that approach?
It would also avoid changing the escaping logic discussed in the other comment thread.
cushon
approved these changes
Sep 11, 2023
guw
changed the title
copybara-service bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
Add a test to reproduce bazelbuild/bazel#19360 Fixes #272 FUTURE_COPYBARA_INTEGRATE_REVIEW=#272 from guw:main b2b7c2b PiperOrigin-RevId: 564393335
treblereel
pushed a commit
to treblereel/turbine
that referenced
this pull request
Sep 28, 2023
Add a test to reproduce bazelbuild/bazel#19360 Fixes google#272 COPYBARA_INTEGRATE_REVIEW=google#272 from guw:main b2b7c2b PiperOrigin-RevId: 564447484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to reproduce bazelbuild/bazel#19360