-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh rules at runtime for Yara Analyser Job #1550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment on possible rate limit issues from Git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one minor comment about the exception that's being caught.
Regarding rate limits, hopefully it won't cause any issues if we do run into this since we will fail open in that case.
Description of the change
Refresh the rules at runtime for the Yara Analyser Job. As we the inital ruleset is build into the worker image they will (without this PR) only be updated when a new worker iamge is build. This PR updates the rules when the Yara Analysis Job is executed.
Applicable issues
None
Additional information
This PR also:
Checklist