Update navtree.js DOM text reinterpreted as HTML #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @odbol Could You Please Review This PR |
|
Hi @odbol or @andreasnilsson Could You Please Review This PR |
|
Hi @odbol or @andreasnilsson Could You Please Review This PR |
|
I'm not convinced this is actually a vulnerability. Can you please provide an example of how someone could inject XSS using this? |
|
Hi @odbol Thanks For Reviewing PR However, textContent is vastly preferred over innerText OR Innerhtml https://kellegous.com/j/2013/02/27/innertext-vs-textcontent/ https://builtin.com/software-engineering-perspectives/innerhtml-vs-innertext Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using textContent, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML.