Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): add Fuzz tests #128

Merged
merged 1 commit into from
Aug 22, 2023
Merged

chore(tests): add Fuzz tests #128

merged 1 commit into from
Aug 22, 2023

Conversation

noahdietz
Copy link
Collaborator

Add Go-native Fuzz tests for Parse, ParseBytes, and FromBytes.

Ideally, we integrate this with OSS-Fuzz instead of running in our own CI.

Copy link

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@noahdietz noahdietz merged commit 542ddab into google:master Aug 22, 2023
@quartzmo
Copy link

Ideally, we integrate this with OSS-Fuzz instead of running in our own CI.

@noahdietz What are the advantages of using OSS-Fuzz? The setup for Go seems pretty involved. What are the limitations of standard Go fuzzing on our own CI?

@noahdietz noahdietz deleted the fuzz branch August 22, 2023 17:21
@noahdietz
Copy link
Collaborator Author

Ideally, we integrate this with OSS-Fuzz instead of running in our own CI.

@noahdietz What are the advantages of using OSS-Fuzz? The setup for Go seems pretty involved. What are the limitations of standard Go fuzzing on our own CI?

OSS-Fuzz is a continuous Fuzzing system that will run our fuzz tests for very extended periods of time. The opportunity for fuzzing to find an issue can be improved by running said tests for a long time (lots and lots and lots of varied input). By integrating with OSS-Fuzz, we offload the responsibility of having to fuzz on our own for long periods of time. The fuzzing I've added here can be used, so we still control what is being fuzzed, and we will use Go-native fuzzing (these tests).

Plus someone already set it up for the original version of this project here that didn't have fuzz tests already, so it should be easier :)

@quartzmo
Copy link

OK, thanks. I guess we can leave it up to OSS-Fuzz to determine how much fuzzing is appropriate.

tkarrass pushed a commit to tkarrass/uuid that referenced this pull request Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants