Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMD: Time-based UUID Generator & Parser #85

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

pedroalbanese
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Jun 22, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Collaborator

@pborman pborman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this. Before it is checked in it will need documentation (package comment) and a copyright statement.

Also, it appears to assume a V1 UUID. It should be checking to see what type of UUID it is and then display the information from the UUID based on the type of UUID. A V4 UUID, for example, will only have random data and no timestamp.

@pedroalbanese
Copy link
Author

Greetings!

Sorry, but can I just remove the random function for now? I mean, I did this implementation because I can't cross-compile OSSP-uuid for armel (my phone), honestly I don't use the Random function. I did it for testing, but I only use time-based uuid. Can I implement it in the future?

@pedroalbanese pedroalbanese changed the title CMD: UUID Generator & Parser CMD: Time-based UUID Generator & Parser Dec 3, 2021
@pedroalbanese pedroalbanese requested a review from pborman December 7, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants