fix: Revert Vector2 constructor changes #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping again @rakudrama and @johnmccutchan, in case you haven't seen all the updated PRs which should bring everything back to order. |
johnmccutchan
approved these changes
Oct 18, 2023
|
Hey @johnmccutchan, my monthly check-in on these PRs. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts back the named constructors of Vector2 to factory constructors so that we can continue with the the Vector3 and Vector4 changes in #294 and #295.
Ping @rakudrama and @johnmccutchan, the other PRs are also updated to remove the named constructors.