Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal errors in Syscall.CallAsync are always silent #124

Closed
dbarnett opened this issue Feb 23, 2015 · 2 comments
Closed

Internal errors in Syscall.CallAsync are always silent #124

dbarnett opened this issue Feb 23, 2015 · 2 comments
Labels
Milestone

Comments

@dbarnett
Copy link
Contributor

Since the Syscall.CallAsync implementation runs vim --remote-expr … in a subshell and ignores the exit code and output, any errors in forwarding the results back into vim are silently ignored. For example, any problems with the shell command we build like quoting/escaping bugs would result in the handler just never getting called even if the original command itself succeeded. That would be insanely hard for callers to debug.

We should figure out a way to capture those error details and bubble them up.

@dbarnett dbarnett added the bug label Feb 23, 2015
@dbarnett
Copy link
Contributor Author

Also swallows errors thrown in the callback, I think.

@dbarnett
Copy link
Contributor Author

Fixed it to shout any errors that occur in the callback itself. I don't think we're going to be able to do much about errors in the shell and the like, but I think we'll call this "fixed" anyway. We'll have a more robust blessed option once we land native job support (#184 for vim, #125 for neovim).

@dbarnett dbarnett added this to the 1.13.0 milestone Mar 27, 2017
dbarnett added a commit that referenced this issue Mar 27, 2017
Changes since 1.12.0:
  * Syscall.CallAsync improvements (#180, #124, #183).
  * Fix maktaba#log# error on reload (#187).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant