Invoke RetryPolicy#retry in the blocking executor. #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the synchronous RequestQueue, retry will be invoked in the NetworkDispatcher thread. Clients may be relying on the ability to perform blocking operations in retry(); a common example would be clearing auth tokens in the event of an auth error, which may require disk I/O. In order to keep the same API contract when using AsyncRequestQueue, rework NetworkUtility to permit BasicAsyncNetwork to invoke retry in the blocking executor.
sophiahaim
approved these changes
Feb 3, 2021
| } | ||
| } else { | ||
| // 3xx? No reason to retry. | ||
| throw new ServerError(networkResponse); |
There was a problem hiding this comment.
Is this needed? You have it again below
There was a problem hiding this comment.
Nope, just needed to generalize the comment. Done.
This was referenced Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the synchronous RequestQueue, retry will be invoked in the
NetworkDispatcher thread. Clients may be relying on the ability to
perform blocking operations in retry(); a common example would be
clearing auth tokens in the event of an auth error, which may
require disk I/O.
In order to keep the same API contract when using AsyncRequestQueue,
rework NetworkUtility to permit BasicAsyncNetwork to invoke retry in
the blocking executor.