Fix weirdly duplicated system hijack output on python 3.7 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An intentional behavior change in python re.sub added a second empty match and "substitution" for '.*' (https://bugs.python.org/issue32308). This changed the catch-all regex vroom was using to an anchored '^.*$', which will ensure it only makes one substitution. Fixes #110.
malcolmr
approved these changes
Jan 21, 2020
|
If a line is always non-empty or if you do not want to replace empty line, you can use |
|
@serhiy No, the intention for this code is more "replace whatever contents were there", so a more selective pattern like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An intentional behavior change in python re.sub added a second empty
match and "substitution" for
'.*'(https://bugs.python.org/issue32308).This changed the catch-all regex vroom was using to an anchored
'^.*$',which will ensure it only makes one substitution.
Fixes #110.