Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple changes to the validity package. #41

Merged
merged 1 commit into from
May 19, 2020
Merged

Multiple changes to the validity package. #41

merged 1 commit into from
May 19, 2020

Conversation

yuizumi
Copy link
Contributor

@yuizumi yuizumi commented May 15, 2020

  • Add FixedURL: use the same validity URL for all resources.
  • Rename ValidityURLRule to URLRule to reduce the redundancy; it makes golint happier.
  • Split url.go into url_rule.go and append_ext.go; having all rules in a single source file makes it too large.
  • Use http.ParseTime instead of httpheader.ParseDate (our own code).

banaag
banaag reviewed May 15, 2020
View reviewed changes
validity/url_rule.go Outdated
// to the request URL but different in some cases; see package urlrewrite
// for more details.
//
// Note ValidityURLRule implementations can retrieve the request URL via
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ValidityURLRule -> URLRule?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch.

banaag
banaag reviewed May 15, 2020
View reviewed changes
Copy link
Collaborator

@banaag banaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM but travis is broken, could you take a look?

@yuizumi
Multiple changes to the validity package.
6d38121 
- Add FixedURL: use the same validity URL for all resources.
- Rename ValidityURLRule to URLRule to reduce the redundancy; it makes
  golint happier.
- Split url.go into url_rule.go and append_ext.go; having all rules in
  a single source file makes it too large.
- Use http.ParseTime instead of httpheader.ParseDate (our own code).
@yuizumi
Copy link
Contributor Author

yuizumi commented May 16, 2020

The build is now fixed (by #42).

@yuizumi
Copy link
Contributor Author

yuizumi commented May 19, 2020

Thanks!

@yuizumi yuizumi merged commit d6513cf into master May 19, 2020
@yuizumi yuizumi deleted the yz.vurl branch May 19, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banaag banaag banaag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuizumi @banaag