Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for failing windows runs #1150

Merged
merged 7 commits into from
Aug 5, 2024
Merged

Quick fix for failing windows runs #1150

merged 7 commits into from
Aug 5, 2024

Conversation

aomarks
Copy link
Member

@aomarks aomarks commented Aug 5, 2024

The new GitHub caching setup system (see #1146) is not working on Windows. The Wireit processes are unable to fetch from the local custodian server.

I'm not sure why yet, but in the meantime this release will make it non-fatal when GitHub caching fails to set up.

Also shows more info when a fetch error occurs, and fixes an issue with environment variable inheritance in our integration tests.

@aomarks aomarks requested review from rictic and augustjk August 5, 2024 21:43
@aomarks aomarks enabled auto-merge (squash) August 5, 2024 21:44
@aomarks aomarks disabled auto-merge August 5, 2024 21:58
@aomarks aomarks enabled auto-merge (squash) August 5, 2024 21:59
@aomarks aomarks disabled auto-merge August 5, 2024 21:59
@aomarks aomarks enabled auto-merge (squash) August 5, 2024 21:59
@aomarks aomarks merged commit 742c56b into main Aug 5, 2024
20 checks passed
@aomarks aomarks deleted the windows-cache branch August 5, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants