Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to stable #133

Merged
merged 45 commits into from
Sep 24, 2024
Merged

Merge main to stable #133

merged 45 commits into from
Sep 24, 2024

Conversation

rstz
Copy link
Collaborator

@rstz rstz commented Sep 24, 2024

No description provided.

rstz and others added 30 commits August 23, 2024 02:55
… most problematic options

PiperOrigin-RevId: 666714677
This is a breaking change that will allow us more flexibility in re-ordering the hyperparameters.

PiperOrigin-RevId: 668342872
PiperOrigin-RevId: 668404720
PYDF exposes some parameters on every learner that are only supported on some of them. This change cleans up the lists of hyperparameters.

This change also fixes some of the documentation of the learners.

PiperOrigin-RevId: 668420630
PiperOrigin-RevId: 668905381
PiperOrigin-RevId: 670559565
The training condition evaluation is composed of a loop over the examples and a switch over the condition type (and a few other things). Prior to this change, the example loop was outside the condition switch loop, forcing the algorithm to re-check the condition type (and other things) for each examples. After this change, the condition type is outside of the example loop.

Example of speed-ups:
1. Average speed-up of 3.7% on all benchmark.
2. Speed-up of 10-15% on Adult dataset with GBT.
3. Speed-up of 8% on Adult dataset with RF.
4. Speed-up of 9% on 4M dataset with 200 features with discretized GBT.
5. No speed difference (<1% gain) on 4M dataset with 200 features non-discretized GBT. Note: The absolute gain is the same as 4., but since 5.'s training is longer, the relative gain is insignificant.

PiperOrigin-RevId: 670888905
PiperOrigin-RevId: 671322125
PiperOrigin-RevId: 672518215
…on supported task.

PiperOrigin-RevId: 673362728
PiperOrigin-RevId: 673852441
PiperOrigin-RevId: 675094172
PiperOrigin-RevId: 675114325
We want to make the truncation parameter configurable. Renaming the loss is the first step.

PiperOrigin-RevId: 675162089
rstz and others added 15 commits September 16, 2024 10:04
PiperOrigin-RevId: 675508141
…Default to 10 seconds.

PiperOrigin-RevId: 675552053
…ust.

This adds support for Unicode strings, normalizes categorical set values in the same way as categorical values, and validates their types.

As a consequence, boolean values in categorical sets are converted to lowercase, matching the treatment of categorical features.

PiperOrigin-RevId: 675906253
PiperOrigin-RevId: 675978237
This change adds a few fixes to the NDCG truncation
- Add a Python test that the learner correctly truncates
- Simplify the proto by re-using the existing LambdMart options proto
- Set the different ranking options as mutually exclusive hyperparameters
- Fix the definition of the truncation hyperparameters as integers

PiperOrigin-RevId: 676387366
Old: learner/gradient_boosted_trees/gradient_boosted_trees.proto
New: model/gradient_boosted_trees/gradient_boosted_trees.proto
PiperOrigin-RevId: 676396458
PiperOrigin-RevId: 676427940
Boolean features are split deterministically with positive going to the right and negative going to the left.

PiperOrigin-RevId: 676796602
PiperOrigin-RevId: 676926239
PiperOrigin-RevId: 677766701
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@rstz rstz merged commit ddba189 into stable Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants