-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix breakage stemming from Syn MSRV bump #1085
Comments
Could also consider committing a MSRV compatible See also Verifying rust-version and Verifying Latest Dependencies for some CI pracitices. |
Update: this is now affecting 0.7 after syn 2.0.68 bumped its MSRV from 1.60 (which is zerocopy 0.7's MSRV) to 1.61. |
joshlf
added a commit
that referenced
this issue
Jul 2, 2024
This also bumps zerocopy-derive's syn dependency to 2.0.46. We don't actually need this for zerocopy-derive. However, in CI, we modify zerocopy-derive to take an "exact" dependency on syn (ie, '=2.0.46' instead of '2.0.46'). One of the transitive dependencies of our `testutil` crate requires syn 2.0.46 or later. We could in principle make CI smart enough to test with both syn versions, but we wouldn't gain much for that complexity - it's easier to just bump the version. Fixes #1085 See also #1481
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 2, 2024
Makes progress on #1085
joshlf
added a commit
that referenced
this issue
Jul 2, 2024
This also bumps zerocopy-derive's syn dependency to 2.0.46. We don't actually need this for zerocopy-derive. However, in CI, we modify zerocopy-derive to take an "exact" dependency on syn (ie, '=2.0.46' instead of '2.0.46'). One of the transitive dependencies of our `testutil` crate requires syn 2.0.46 or later. We could in principle make CI smart enough to test with both syn versions, but we wouldn't gain much for that complexity - it's easier to just bump the version. Fixes #1085 See also #1481
github-merge-queue bot
pushed a commit
that referenced
this issue
Jul 2, 2024
This also bumps zerocopy-derive's syn dependency to 2.0.46. We don't actually need this for zerocopy-derive. However, in CI, we modify zerocopy-derive to take an "exact" dependency on syn (ie, '=2.0.46' instead of '2.0.46'). One of the transitive dependencies of our `testutil` crate requires syn 2.0.46 or later. We could in principle make CI smart enough to test with both syn versions, but we wouldn't gain much for that complexity - it's easier to just bump the version. Fixes #1085 See also #1481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Starting with #1081, our nightly toolchain roller began to fail. The cause was syn increasing its MSRV to 1.60 from 1.56. Our MSRV remains at 1.56, so CI builds on that toolchain began to fail to resolve a suitable version of syn.
The timeline of events on syn's side is a little confusing:
dep:
and optional dependency feature?
syntax dtolnay/syn#1608Not yet sure how we should proceed with this. A few possibilities that spring to mind:
-Z minimal-versions
The text was updated successfully, but these errors were encountered: