Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and test that validation order is consistent #1331

Open
jswrenn opened this issue May 21, 2024 · 1 comment
Open

Audit and test that validation order is consistent #1331

jswrenn opened this issue May 21, 2024 · 1 comment

Comments

@jswrenn
Copy link
Collaborator

jswrenn commented May 21, 2024

Our conversion methods should perform their runtime validation checks in a consistent order; e.g., checking alignment, then size, then bit validity. This ordering should be both internally consistent, and, ideally, SemVer stable.

@jswrenn jswrenn added the blocking-next-release This issue should be resolved before we release on crates.io label May 21, 2024
joshlf added a commit that referenced this issue Jun 24, 2024
@jswrenn jswrenn removed the blocking-next-release This issue should be resolved before we release on crates.io label Jun 24, 2024
@jswrenn
Copy link
Collaborator Author

jswrenn commented Jun 24, 2024

Removed the blocking-next-release This issue should be resolved before we release on crates.io label, in favor of the more moderate approach of documented that we strive for a particular validation order, but we do not actually guarantee it.

github-merge-queue bot pushed a commit that referenced this issue Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant