Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test infallible alignment errors in Fuchsia, then remove Ref unaligned constructors #1720

Closed
Tracked by #671
joshlf opened this issue Sep 21, 2024 · 1 comment · Fixed by #1723
Closed
Tracked by #671

Test infallible alignment errors in Fuchsia, then remove Ref unaligned constructors #1720

joshlf opened this issue Sep 21, 2024 · 1 comment · Fixed by #1723
Labels
blocking-next-release This issue should be resolved before we release on crates.io

Comments

@joshlf
Copy link
Member

joshlf commented Sep 21, 2024

With #1718, we can likely remove the unaligned constructors from Ref. However, we should first confirm that this is doable by vendoring #1718 into Fuchsia and attempting to remove all unaligned uses from tree.
@joshlf joshlf added the blocking-next-release This issue should be resolved before we release on crates.io label Sep 21, 2024
This was referenced Sep 21, 2024
Open
Merged
@joshlf
Copy link
Member Author

joshlf commented Sep 21, 2024

Vendored into Fuchsia successfully.

joshlf added a commit that referenced this issue Sep 21, 2024
@joshlf
[Ref] Remove unaligned constructors
77e012b 
Closes #1720
@joshlf joshlf mentioned this issue Sep 21, 2024
Merged
joshlf added a commit that referenced this issue Sep 21, 2024
@joshlf
[Ref] Remove unaligned constructors
56e1250 
Closes #1720
joshlf added a commit that referenced this issue Sep 21, 2024
@joshlf
[Ref] Remove unaligned constructors
376dab3 
Closes #1720
github-merge-queue bot pushed a commit that referenced this issue Sep 22, 2024
@joshlf
[Ref] Remove unaligned constructors (#1723)
2405a94 
Closes #1720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocking-next-release This issue should be resolved before we release on crates.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ref] Remove unaligned constructors google/zerocopy
1 participant
@joshlf