Rename TryFromBytes methods to be consistent with FromBytes
#1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
requested changes
Apr 18, 2024
src/lib.rs
Outdated
| /// [*valid instance*]: #what-is-a-valid-instance | ||
| #[cfg_attr(feature = "derive", doc = "[derive]: zerocopy_derive::TryFromBytes")] | ||
| #[cfg_attr( | ||
| not(feature = "derive"), | ||
| doc = concat!("[derive]: https://docs.rs/zerocopy/", env!("CARGO_PKG_VERSION"), "/zerocopy/derive.TryFromBytes.html"), | ||
| )] | ||
| // TODO(#5): Update `try_from_ref` doc link once it exists | ||
| // TODO(#5): Update `try_ref_from` doc link once it exists |
There was a problem hiding this comment.
Is this TODO done? Can we remove it while we're here?
jswrenn
force-pushed
the
tfb-method-consistency
branch
from
b9eae53
to
07d9841
Compare
Still need to do this ^ |
jswrenn
force-pushed
the
tfb-method-consistency
branch
from
07d9841
to
0135034
Compare
|
Whoops, missed that. Done. |
joshlf
approved these changes
Apr 18, 2024
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example,
try_from_refis nowtry_ref_from.See: #1095