[derive] Test TryFromBytes output on dataful enums #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
test-dataful-enum-derive-output
branch
2 times, most recently
from
34f9091
to
32544ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1665 +/- ##
=======================================
Coverage 88.01% 88.01%
=======================================
Files 16 16
Lines 5805 5805
=======================================
Hits 5109 5109
Misses 696 696 ☔ View full report in Codecov by Sentry. |
jswrenn
approved these changes
Sep 16, 2024
| test_derive! { | ||
| TryFromBytes { | ||
| #[repr(u8)] | ||
| enum ComplexWithGenerics<X, Y> { |
There was a problem hiding this comment.
Unless it causes a failure (in which case, do this in a follow-up PR), could your example here include lifetimes, types, and const generics with a mix of inline and where bounds?
There was a problem hiding this comment.
Discussed offline. We'll follow up on this in another PR.
joshlf
force-pushed
the
test-dataful-enum-derive-output
branch
from
32544ae
to
4fe9719
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #367, #1634