Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make map_src public on error types #1686

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Make map_src public on error types #1686

merged 1 commit into from
Sep 19, 2024

Conversation

jswrenn
Copy link
Collaborator

@jswrenn jswrenn commented Sep 19, 2024

Closes #1297

@jswrenn jswrenn requested a review from joshlf September 19, 2024 19:47
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (70f3e14) to head (d85c48e).

Files with missing lines Patch % Lines
src/error.rs 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   88.01%   87.91%   -0.10%     
==========================================
  Files          16       16              
  Lines        5805     5811       +6     
==========================================
  Hits         5109     5109              
- Misses        696      702       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 421c42f Sep 19, 2024
80 checks passed
@joshlf joshlf deleted the map_src branch September 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make error types usable in more contexts
3 participants