Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Roll pinned nightly toolchain #1927

Conversation

google-pr-creation-bot
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@jswrenn jswrenn force-pushed the roll-pinned-nightly-toolchain-to-nightly-2024-10-16-for-v0.8.x branch from 03181be to 6e98a9e Compare October 17, 2024 13:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.59%. Comparing base (0bee231) to head (ed7972b).

Additional details and impacted files
@@           Coverage Diff           @@
##           v0.8.x    #1927   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files          16       16           
  Lines        5988     5988           
=======================================
  Hits         5245     5245           
  Misses        743      743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jswrenn
Copy link
Collaborator

jswrenn commented Oct 17, 2024

Whaaaat?

error: unknown lint: `non_local_definitions`
   --> src/lib.rs:206:10
    |
206 | #![allow(non_local_definitions, unknown_lints, unreachable_patterns)]
    |          ^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `-D unknown-lints` implied by `-D warnings`

@joshlf, do you know why the explicit allow of unknown_lints is being ignored?

Ah, it's order-dependent.

And allow `non_local_definitions`.
@jswrenn jswrenn force-pushed the roll-pinned-nightly-toolchain-to-nightly-2024-10-16-for-v0.8.x branch from 6e98a9e to ed7972b Compare October 17, 2024 14:00
@jswrenn jswrenn added this pull request to the merge queue Oct 17, 2024
Merged via the queue into google:v0.8.x with commit a8e58c1 Oct 17, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants