[project] Initial commit #1934
Open
[project] Initial commit #1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This supersedes #1933, which has a soundness hole. This only supports sized types for now, but maybe we'll figure out a way to lift that limitation eventually. |
joshlf
force-pushed
the
I54eb863c96f056738f58727fc0fec4e1630bf97a
branch
4 times, most recently
from
451d820 to
21338e0
Compare
TODO: Could we support unsized types so long as we never call offset_of! on the trailing unsized field? TODO: Use `Name` type parameter trick to emit better error messages: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=97771667892860935bea60b218f8fdf4 gherrit-pr-id: I54eb863c96f056738f58727fc0fec4e1630bf97a
joshlf
force-pushed
the
I54eb863c96f056738f58727fc0fec4e1630bf97a
branch
from
21338e0 to
5ef235b
Compare
kupiakos
reviewed
Oct 22, 2024
| impl<'a, T, I> Ptr<'a, T, I> | ||
| where | ||
| T: 'a + ?Sized, | ||
| I: Invariants, |
There was a problem hiding this comment.
Note that this can only ever be sound for invariants that structurally propagate to their fields. This doesn't apply for the Pin invariant.
kupiakos
reviewed
Oct 22, 2024
| // NOTE: Doing the actual cast inside this function makes the `project!` | ||
| // macro simpler, but it also means that we can't handle both const code and | ||
| // unsized types at the same time. In order to be const, we can't call trait | ||
| // methods, but in order to support unsized types, we'd need to provide a |
There was a problem hiding this comment.
For slice DSTs, all you need is the offset of the last field, which is the same for all sizes. This could be stored as a const.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Could we support unsized types so long as we never call offset_of!
on the trailing unsized field?
TODO: Use
Nametype parameter trick to emit better error messages:https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=97771667892860935bea60b218f8fdf4
This PR is on branch projection-sized.