Enforce Src: FromBytes in try_transmute_mut!
#2229
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
force-pushed
the
fix-try_transmute_mut
branch
from
69ad562 to
2bf3099
Compare
|
(Have a killer headache tonight; I'll finish this up first thing tomorrow.) |
Ensures that the source reference remains valid after the transmuted (and possibly mutated) destination is dropped. Fixes #2226
jswrenn
force-pushed
the
fix-try_transmute_mut
branch
from
2bf3099 to
4fdd646
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #2229 +/- ##
==========================================
- Coverage 87.42% 87.41% -0.01%
==========================================
Files 16 16
Lines 6115 6111 -4
==========================================
- Hits 5346 5342 -4
Misses 769 769 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the source reference remains valid after the transmuted (and possibly mutated) destination is dropped.
Fixes #2226