Fix alignment tests for targets with pointer width < 8 bytes #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
frazar
force-pushed
the
fix-alignment-test
branch
2 times, most recently
from
bb4e3fe
to
8e3852c
Compare
frazar
changed the title
frazar
force-pushed
the
fix-alignment-test
branch
2 times, most recently
from
2c30281
to
392f850
Compare
joshlf
reviewed
Oct 6, 2022
joshlf
reviewed
Oct 6, 2022
|
Awesome, thanks so much for this, @frazar ! Welcome to zerocopy 😃 A few small nits, but this looks great! |
frazar
force-pushed
the
fix-alignment-test
branch
from
392f850
to
9c55d2c
Compare
|
Thank you for your review and your nice words! Should be ready for merge now. |
joshlf
reviewed
Oct 7, 2022
|
np! One more small nit and we should be ready to merge. |
The alignment tests relied on the fact that the pointer width is 8 bytes, which is not the case for i686. Fix the alignment tests so that they work on targets with pointer width of 4 or even 2 bytes. Fixes google#21
frazar
force-pushed
the
fix-alignment-test
branch
from
9c55d2c
to
04cbd2e
Compare
|
Added the dots to the comments, should be ok now. |
joshlf
approved these changes
Oct 7, 2022
joshlf
pushed a commit
that referenced
this pull request
Oct 10, 2022
joshlf
pushed a commit
that referenced
this pull request
Aug 3, 2023
The alignment tests relied on the fact that the pointer width is 8 bytes, which is not the case for i686. Fix the alignment tests so that they work on targets with pointer width of 4 or even 2 bytes. Fixes #21
joshlf
pushed a commit
that referenced
this pull request
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alignment tests relied on the fact that the pointer width is 8 bytes, which is not the case for i686.
Fix the alignment tests so that they work on targets with pointer width of 4 or even 2 bytes.
Fixes #21