-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[derive] Simplify code, remove obsolete features #361
Merged
joshlf
merged 0 commits into
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
from
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
Sep 12, 2023
Merged
[derive] Simplify code, remove obsolete features #361
joshlf
merged 0 commits into
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
from
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 9, 2023 22:10
322e9ac
to
847196f
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 9, 2023 22:10
e22c6d0
to
b62e2ec
Compare
joshlf
commented
Sep 9, 2023
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
2 times, most recently
from
September 10, 2023 00:40
7310ef5
to
c810adc
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 10, 2023 00:40
b62e2ec
to
59e8401
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 10, 2023 06:33
c810adc
to
886b4c7
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 10, 2023 06:34
59e8401
to
4891c4f
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 10, 2023 19:05
886b4c7
to
bc62dc6
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 10, 2023 19:05
4891c4f
to
0f315c7
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 11, 2023 02:59
bc62dc6
to
dfe39c0
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 11, 2023 02:59
0f315c7
to
bfb5bf5
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 11, 2023 03:47
dfe39c0
to
e82b746
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 11, 2023 03:47
bfb5bf5
to
1b18c53
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 11, 2023 19:39
e82b746
to
8db2922
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 11, 2023 19:39
1b18c53
to
87754b2
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 11, 2023 22:28
8db2922
to
774ddaa
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 11, 2023 22:29
87754b2
to
2402ec6
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 11, 2023 22:52
774ddaa
to
fd9b4c1
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 11, 2023 22:52
2402ec6
to
c26336c
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 11, 2023 23:05
fd9b4c1
to
1a330ee
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 11, 2023 23:05
c26336c
to
b9b29a0
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 11, 2023 23:31
1a330ee
to
67a18c0
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 11, 2023 23:31
b9b29a0
to
34016f9
Compare
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
from
September 12, 2023 00:34
67a18c0
to
05e5775
Compare
joshlf
merged commit Sep 12, 2023
05e5775
into
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
joshlf
force-pushed
the
try-from-bytes-raw-argument-to-is-bit-valid-3-try-transmute-macros
branch
from
September 12, 2023 00:34
34016f9
to
1a0b1bb
Compare
joshlf
deleted the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
September 12, 2023 00:34
joshlf
restored the
try-from-bytes-raw-argument-to-is-bit-valid--derive-cleanup
branch
September 12, 2023 00:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the implementation, especially in
fn impl_block
. Make the following notable changes:syn
didn't support parsing macro invocations in const generics without thefull
feature enabled. To avoid the compile-time overhead of that feature, we worked around it by constructing AST nodes manually.syn
has since added support for this without requiring thefull
feature, so we make use of it.[T; 2]
) and those that didn't (like[u8; 2]
). We made a change in Move field type bounds into where clauses #119 that made this distinction irrelevant, but we never removed the code to perform the split. In this commit, we remove that code. That code was the only reason we needed to enablesyn
'svisit
feature, so we are also able to remove that feature dependency.