Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rust Cache invalid key warning #59

Merged
merged 10 commits into from
Oct 14, 2022
Merged

Fix Rust Cache invalid key warning #59

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9a0149c
Try to use string length
AntoniosBarotsis Oct 14, 2022
1dea505
Added on push for testing
AntoniosBarotsis Oct 14, 2022
be88e1f
Print key to make sure that it works
AntoniosBarotsis Oct 14, 2022
ffc1567
Use env variable
AntoniosBarotsis Oct 14, 2022
ef05adc
Removed on push
AntoniosBarotsis Oct 14, 2022
b405aed
Hash features instead of using length
AntoniosBarotsis Oct 14, 2022
dd57333
Enable on push again
AntoniosBarotsis Oct 14, 2022
febf5a5
Renamed param
AntoniosBarotsis Oct 14, 2022
b4f59a8
Removed on push
AntoniosBarotsis Oct 14, 2022
de8f409
Explained new step
AntoniosBarotsis Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,17 @@ jobs:
# https://github.com/actions/runner/issues/409#issuecomment-752775072
components: ${{ contains(matrix.channel, 'nightly') && 'miri' || '' }}

# The features string contains commas which cannot be part of the cache
# key for the Rust Cache action. Instead, we hash the features
# to get a string of legal characters.
- name: Set feature string for cache key
run: |
echo "FEATURES_HASH=$(echo ${{ matrix.features }} | sha256sum | cut -d ' ' -f 1)" >> $GITHUB_ENV
joshlf marked this conversation as resolved.
Show resolved Hide resolved

- name: Rust Cache
uses: Swatinem/rust-cache@v2.0.0
with:
key: "${{ matrix.channel }}-${{ matrix.target }}-${{ matrix.features }}-${{ hashFiles('**/Cargo.lock') }}"
key: "${{ matrix.channel }}-${{ matrix.target }}-${{ env.FEATURES_HASH }}-${{ hashFiles('**/Cargo.lock') }}"

- name: Check
run: cargo +${{ matrix.channel }} check --target ${{ matrix.target }} --features "${{ matrix.features }}" --verbose
Expand Down