Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkedCustomerId header is not set when using GoogleAdsClientBuilder #902

Closed
heyhsieh opened this issue May 1, 2023 · 2 comments
Closed

LinkedCustomerId header is not set when using GoogleAdsClientBuilder #902

heyhsieh opened this issue May 1, 2023 · 2 comments
Assignees
@fiboknacky
Labels
bug Something isn't working difficulty: easy Easy; good for newcomers or beginners enhancement New feature or request good first issue Good for newcomers P2 Work that should be prioritized. Bugs classified here have known reasonable workarounds triage Need triage

Comments

@heyhsieh
Copy link

heyhsieh commented May 1, 2023

  • Client library version: 19.1.0
  • Google Ads API version: 13

Description of the bug:
The linked customer id header is not sent when it is configured via the GoogleAdsClientBuilder. Calling withLinkedCustomerId will set the linkedCustomerId property in the builder. However the headers are set by the addFixedHeaderMiddleware method in GoogleAdsGapicClientTrait, which sets the developer token and login customer id headers but doesn't account for the linked customer id LINK.

I found a similar issue that was reported for login-customer-id LINK.
@heyhsieh heyhsieh added bug Something isn't working triage Need triage labels May 1, 2023
@fiboknacky fiboknacky self-assigned this May 2, 2023
@fiboknacky fiboknacky added good first issue Good for newcomers difficulty: easy Easy; good for newcomers or beginners P2 Work that should be prioritized. Bugs classified here have known reasonable workarounds labels May 2, 2023
@fiboknacky
Copy link
Member

Thanks for reporting. We'll get back to this as soon as we can.

@fiboknacky fiboknacky added the enhancement New feature or request label Jun 15, 2023
@fiboknacky
Copy link
Member

Fixed with v20.1.0

fiboknacky added a commit that referenced this issue Aug 21, 2023
@fiboknacky
Pass linked-customer-id to the headers of requests when it's set.
fa48784 
Previously, it was set and passed to the service client, but it's half
done, and not properly set as a part of the headers.

This fixes #902.

Bug: N/A
Golden CLs: N/A

Change-Id: Ibbdbff073f89a739a6c391621ead69ec59645f1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fiboknacky fiboknacky

Labels
bug Something isn't working difficulty: easy Easy; good for newcomers or beginners enhancement New feature or request good first issue Good for newcomers P2 Work that should be prioritized. Bugs classified here have known reasonable workarounds triage Need triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fiboknacky @heyhsieh