-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of namespace property to support Android Gradle Plugin (AGP) 8 #839
Comments
Thanks for the report. This issue is reproduced on the latest ads plugin version flutter doctor -v (stable and master)[✓] Flutter (Channel stable, 3.10.0, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
• Flutter version 3.10.0 on channel stable at /Users/huynq/Documents/GitHub/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 84a1e904f4 (35 hours ago), 2023-05-09 07:41:44 -0700
• Engine revision d44b5a94c9
• Dart version 3.0.0
• DevTools version 2.23.1
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
• Android SDK at /Users/huynq/Library/Android/sdk
• Platform android-33, build-tools 32.0.0
• ANDROID_HOME = /Users/huynq/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E222b
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
[✓] VS Code (version 1.78.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.62.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-x64 • macOS 13.0.1 22A400 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 113.0.5672.92
[✓] Network resources
• All expected network resources are available.
• No issues found! [!] Flutter (Channel master, 3.11.0-5.0.pre.47, on macOS 13.0.1 22A400 darwin-x64, locale en-VN)
• Flutter version 3.11.0-5.0.pre.47 on channel master at /Users/huynq/Documents/GitHub/flutter_master
! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 43b2b658a0 (2 hours ago), 2023-05-11 21:14:09 -0400
• Engine revision 748ef964b9
• Dart version 3.1.0 (build 3.1.0-94.0.dev)
• DevTools version 2.23.1
• If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.
[✓] Android toolchain - develop for Android devices (Android SDK version 32.0.0)
• Android SDK at /Users/huynq/Library/Android/sdk
• Platform android-33, build-tools 32.0.0
• ANDROID_HOME = /Users/huynq/Library/Android/sdk
• Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 14E222b
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2022.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
[✓] VS Code (version 1.78.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.64.0
[✓] Connected device (2 available)
• macOS (desktop) • macos • darwin-x64 • macOS 13.0.1 22A400 darwin-x64
• Chrome (web) • chrome • web-javascript • Google Chrome 113.0.5672.92
[✓] Network resources
• All expected network resources are available.
! Doctor found issues in 1 category. |
Just submitted a PR that should close this issue. |
Is there a workaround for this until this PR is merged? |
@nemanja-nisic Feel free to use the fork if you don't want to wait. In your google_mobile_ads:
git:
url: https://github.com/Skyost/googleads-mobile-flutter
path: packages/google_mobile_ads |
We’re closing this issue due to inactivity. If you’re still impacted, please create a new issue via the Developer Forum. |
Why would you think we are no longer impacted? Anyone who has this in their project cannot upgrade Gradle to version 8+. |
@under3415 Thanks for the update. Re-opening the issue since there is a similar report recently. cc: @malandr2 |
There is a fix for this. We are patiently waiting for it to be merged. So, the lack of activity here is not a sign of resolution, it is just people being polite...
…________________________________
From: huycozy ***@***.***>
Sent: Monday, August 7, 2023 11:58:23 PM
To: googleads/googleads-mobile-flutter ***@***.***>
Cc: under3415 ***@***.***>; Mention ***@***.***>
Subject: Re: [googleads/googleads-mobile-flutter] Add support of namespace property to support Android Gradle Plugin (AGP) 8 (Issue #839)
@under3415<https://github.com/under3415> Thanks for the update. Re-opening the issue since there is a similar report recently.
cc: @malandr2<https://github.com/malandr2>
—
Reply to this email directly, view it on GitHub<#839 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA5N3HQK5FMRDLOFECRPWPTXUDJ57ANCNFSM6AAAAAAX5G3W6Q>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I'm also facing same issue. |
facing the same issue with AGP 8... |
facing the same issue
Stacktrace
|
facing the same issue but does not get any solution. please help in solving this problem... |
Workaround is to reference solution by Skyost in your pubspec.yaml.
|
There is a PR addressing the issue, it has been approved but needs to pass all tests before it can be merge in. Thanks. |
This is still NOT fixed in version |
Right, #843 has not yet been approved and merged in. It will be included in the next release. |
Plugin Version
Latest (3.0.0).
Steps to Reproduce
Upgrade your Android project to use AGP 8. In your
build.gradle
:Also don't forget to add a namespace in the
android
section ofapp/build.gradle
:Then
flutter run
to an Android device (or evenflutter build appbundle
).Expected results:
My app to compile fine.
Actual results:
Stacktrace
More info
See flutter/flutter#125181. It shouldn't be too hard to fix (see the PR I've sent here : https://github.com/bluefireteam/audioplayers/pull/1503/files), but since this project seems to use a custom
build.gradle
, I'm not sure if we can "just" copy and paste it.The text was updated successfully, but these errors were encountered: