-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
videojs-ima fixed style units #492
Comments
Thanks for the report - I'll take a look and make the change once I verify that it doesn't break other stuff. |
@shawnbuso How to reproduce this issue: How to fix this issue: |
This sounds like a separate issue than the first one - could you open a new issue for this so we can track them separately? Thanks! |
How to reproduce this issue:
change font-size of .video-js and play non-linear ad from Google IMA example tags
Example of problematic code:
How to fix this issue:
Use font relative units. For example in case above it should be
margin-top: -3em;
(or around this value)As videojs use
em
units, most of sizes and offsets is related to base font-size of .video-js. So plugins should use same approach to be responsive. You can inspire with native.vjs-text-track-display
overlayer.The text was updated successfully, but these errors were encountered: