-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against VJS 5 and 6 #539
Comments
Hello, I just tested vjs6.6.3 with contrib-ads6.0.0 and vjs-ima1.2.0. I need to know that all(ads and video) completed (to display related videos) so I created custom event 'allcompleted' like this. It is ugly, but hadn't better idea how to do that.
But player.on('ended') has now delay about 5s from time when ads and video really ended. Is this delay expected in new version? I will provide sample page if needed. It also prints warning:
Thanks Btw. I think that ads should be handled through beforeplay and beforeended events to provide place to play preroll and postroll. player's "ended" event should be considered as absolutely final event that tells "there is nothing more to play"... nor add final event to player like 'completed' or so.. With vjs6.6.3, contrib-ads5.16.x and vjs-ima1.1.x, it worked fine without delay (except short blink of original video before preroll started).. |
Thanks for the info! |
|
Sorry. I use minified version. I will provide this error with better description;) |
Ohh, that makes sense. We'll fix this log warning in contrib-ads. This warning is really helpful for debugging these cases. I opened an issue: videojs/videojs-contrib-ads#338 |
I don't use minified file from contrib-ads/dist. I bundle all together through commonJS, browserify and gulp so I'm not sure that it helps. This is non-minified debug warn msg:
|
Interesting, that suggests that Another bit of useful information is if you're seeing an |
I looked at the source a bit and saw |
I will provide sample page with non-minified source within hour.. The issue is that it delays every 'ended' event even if all ads are completed (playing another source, repeat is ok). Meanwhile I logged event order: When I play next, it keeps firing adtimeout (2per one playing) with delayed ended event. |
Sample page: https://games.tiscali.cz/player/vjs-testpage.html |
Interesting, it looks like there is a pause while the player waits for a postroll but no postroll plays, then a postroll timeout, and then the postroll plays after the expected postroll break. This is probably the source of the strange behavior. Does videojs-ima play postrolls on the ended event? For postroll timeouts and ended events to work correctly, postrolls should play on
|
It looks like we are using |
Also changes reset() to verify that we're in an ad break before calling endLinearAdMode(). Addresses comments in #539.
@incompl There is still uncatched endLinearAdMode() call in onAdBreakEnd. It prints warning when postroll ends. I switched if (player.ads.inAdBreak()) to onAdBreakEnd and deleted it in reset method (just oposite as its now) and it works fine (tried only preroll and postroll). The other thing is that I dont know why.) |
With @incompl help we probably found another issue using contrib-ads v6 with ima v1.2.1. videojs/videojs-contrib-ads#358. Can you look at it? This part of code:
From what said incompl, couldnt be this an issue? |
This issue looks resolved. We test vjs 5 and 6 in our Travis tests |
contrib-ads 6 allows us to add support for VJS6. Legacy implementations will like still use VJS5 at least for some time. We should investigate adding support for testing against VJS 5 and 6 instead of just one.
The text was updated successfully, but these errors were encountered: