Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Compatibility Issue by Using video.js 7.x with videojs-ima and videojs-contrib-ads #1150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ale-grosselle
Copy link

In our project, we decided to upgrade video.js to version 8.x to take advantage of the latest features and improvements. However, during the upgrade process, we encountered a module resolution error. The issue arises because we intend to use video.js 8.x, but the videojs-ima plugin depends on videojs-contrib-ads version 6.*, which in turn requires video.js version 7 (see here).

To resolve this issue, we will temporarily revert to video.js version 7.x, as it is compatible with the necessary dependencies. This solution will ensure the seamless integration of videojs-ima and videojs-contrib-ads in our project.

Copy link

google-cla bot commented Jul 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants