Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AIP-4232): support nested field of required field #1339

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

noahdietz
Copy link
Collaborator

When a method signature contains a nested field of a message type field that is required in the top level request message, that should be sufficient to fulfill the "all required fields in method signature" requirement.

Internal bug b/325252841

@noahdietz noahdietz requested a review from a team as a code owner February 19, 2024 20:06
@andrei-scripniciuc andrei-scripniciuc merged commit e86a159 into googleapis:main Feb 20, 2024
6 checks passed
@noahdietz noahdietz deleted the 4232-nested-required branch February 28, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants