fix(AIP-121): recognize standard list revisions #1347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be overtaken by #1348 |
andrei-scripniciuc
approved these changes
Mar 1, 2024
|
This should be necessary anymore since #1348 brings "new" list revisions methods into scope of Standard List. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since AIP-162 recommends Revisions being a proper resource collection, it will also be checked for standard List and Get RPCs as per AIP-121. However, the rule enforcing the Standard List requirement was ignoring list revision methods explicitly. This brings
List{Resource}Revisionsinto consideration for that rule.Fixes internal bug