Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Exclude "main" suffices from version checks. #581

Merged
merged 1 commit into from
Jul 15, 2020
Merged

fix: Exclude "main" suffices from version checks. #581

merged 1 commit into from
Jul 15, 2020

Conversation

lukesneeringer
Copy link
Contributor

No description provided.

@lukesneeringer lukesneeringer requested a review from a team July 15, 2020 04:05
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020
jgeewax
jgeewax approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@jgeewax jgeewax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this, but I don't see the listing of these suffixes as a part of AIP-215. Is that change pending and we're just waiting on it to be merged? If not, we should add a bulleted list of the exceptions, right?

@lukesneeringer
Copy link
Contributor Author

This exception is around internal tooling; what is publicly released still corresponds to AIP-215.

Ultimately the right way to do this sort of thing is with internal extensions but we do not have a good internal way to add a granular exception like this so I am accepting the wart for the moment.

@lukesneeringer lukesneeringer merged commit dc24c16 into master Jul 15, 2020
@lukesneeringer lukesneeringer deleted the aip215-main branch July 15, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgeewax jgeewax jgeewax approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukesneeringer @jgeewax @googlebot