Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: BatchGet rule now singularizes correctly. #585

Merged
merged 3 commits into from
Aug 3, 2020
Merged

fix: BatchGet rule now singularizes correctly. #585

merged 3 commits into from
Aug 3, 2020

Conversation

lukesneeringer
Copy link
Contributor

Fixes #575.

@lukesneeringer lukesneeringer requested a review from a team July 29, 2020 13:10
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2020
@lukesneeringer
Copy link
Contributor Author

@noahdietz: I am out today, so please just merge this on my behalf (assuming you approve/agree).

noahdietz
noahdietz requested changes Jul 29, 2020
View reviewed changes
rules/aip0231/response_resource_field.go Outdated Show resolved Hide resolved
rules/aip0231/response_resource_field.go Outdated Show resolved Hide resolved
@lukesneeringer lukesneeringer merged commit dd1810f into master Aug 3, 2020
@lukesneeringer lukesneeringer deleted the issue-575 branch August 3, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahdietz noahdietz noahdietz approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP 231's response-resource-field does not recognize matches as the plural of match.
2 participants
@lukesneeringer @noahdietz